Refactor librarybuilder, fix bugs, security, build system, and tests - #11
Merged
Conversation
added 4 commits
June 6, 2026 20:50
Bugs fixed: - SQL injection → parameterized queries - Memory leaks → stack variables - No-op delete_row → executes the query - Book.cpp set_sub_genre → assigns correct member Security: - Hardcoded credentials → environment variables Code quality: - Pass-by-value strings → const std::string & - Getters return by const reference - Rule of Five for MovieCollection and BookCollection - Consistent & style (name-attached) Build system: - CMakeLists.txt with main and test targets - Test coverage support via lcov - Google Test framework - Separate test files per collection type Cleanup: - Comments corrected (movie → book where appropriate) - Test includes removed from main.cpp - Table name validation helper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bugs Fixed
Security
Code Quality
Build System
Cleanup